[PATCH] D42112: [PowerPC] Secure PLT support

[Justin Hibbits via Phabricator via llvm-commits]

jhibbits added inline comments.


================
Comment at: test/CodeGen/PowerPC/ppc32-pic-large.ll:14
 
+define i32 @foo1() #0 {
+entry:
----------------
spetrovic wrote:
> jhibbits wrote:
> > I meant instead of copying the same code into these two files and getting the same result as I already put in here, have two RUN lines in the ppc32-pic-large.ll/ppc32-pic.ll -- the existing RUN line, and an additional line to test secure-plt.
> > 
> > Then we'd have lines of LARGE-BSS and LARGE-BSS-SECUREPLT, or such.
> > 
> > The change you made here is effectively just duplicating the test I already wrote.
> Since this solution doesn't support small pic mode, is it OK just to add secure plt checks in ppc32-pic-large.ll ?
That's fine with me.


Repository:
  rL LLVM

https://reviews.llvm.org/D42112