[PATCH] D44083: [MergICmps] Make sure that the comparison only has one use.
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 12 06:43:08 PDT 2018
spatel added inline comments.
================
Comment at: lib/Transforms/Scalar/MergeICmps.cpp:186-188
+ // The comparison can only be used once:
+ // - For intermediate blocks, as a branch condition.
+ // - For the final block, as an incoming value for the Phi.
----------------
The change looks safe and fixes the bug. But I haven't looked at the whole pass, so it's not clear to me why we should have the restriction. Can you add something to the comment to explain?
Repository:
rL LLVM
https://reviews.llvm.org/D44083
More information about the llvm-commits
mailing list