[PATCH] D44290: Handle mixed-OS paths in DWARF reader

[Eugene Zemtsov via Phabricator via llvm-commits]

eugene added a comment.

In https://reviews.llvm.org/D44290#1034041, @zturner wrote:

> Is there some kind of field we can write inside the DWARF that can tell us what path syntax to assume?


As far as I know DWARF doesn't have a field like this.

> I'm a little weary about trying to guess.  It seems like there could be lots of edge cases where we incorrectly determine what syntax a path is using.

I share your worry for the general practice, but in this particular case I think it's ok. 
If path is absolute on any OS (starts with / or X:) the code will treat it like it is absolute, and just won't try to concatenate more things together.

On Windows Android NDK produces binaries where different CUs have different path styles. Those binaries need to be symbolized on Linux and Mac OS, hence this change removing assumption that path style is always native.


https://reviews.llvm.org/D44290