[PATCH] D44364: [AMDGPU] Fix the SDWA Peephole phase to handle src for dst:UNUSED_PRESERVE.

Michael Bedy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 10 20:15:41 PST 2018


mjbedy created this revision.
Herald added subscribers: llvm-commits, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, kzhuravl, arsenm.

The phase attempts to transform operations that extract a portion of a value
into an SDWA src operand in cases where that value is used only once. It
was not prepared for this use to be the preserved portion of a value for
dst:UNUSED_PRESERVE, resulting in a crash or assert.

This change either rejects the illegal SDWA attempt, or in the case where
dst:WORD_1 and the src_sel would be WORD_0, removes the unneeded
extract instruction.


Repository:
  rL LLVM

https://reviews.llvm.org/D44364

Files:
  lib/Target/AMDGPU/SIPeepholeSDWA.cpp
  test/CodeGen/AMDGPU/sdwa-preserve.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44364.137941.patch
Type: text/x-patch
Size: 9250 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180311/c6a9ef94/attachment.bin>


More information about the llvm-commits mailing list