[PATCH] D43097: [WebAssembly] Allow for the creation of user-defined custom sections

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 10 17:43:03 PST 2018


sbc100 added a comment.

In https://reviews.llvm.org/D43097#1033939, @ncw wrote:

> How do you expect the linker to handle these custom sections? We currently discard them. Will there be semantics for how to merge them, if there are name clashes, etc...?
>
> I can't see a problem with the code and approach - don't wait on my review - but I'm just a bit hazy on the end-to-end story for bindings generators (which presumably will have to hook into things at the C level via a new attribute?)


I imagine that sections with the same name should be concatenated (with relocations as needed).  At least this is what I think the linker currently does for debug sections in ELF.  I could be wrong though.


Repository:
  rL LLVM

https://reviews.llvm.org/D43097





More information about the llvm-commits mailing list