[PATCH] D44348: [WebAssembly] Generate imports for undefined data as well as functions
    Sam Clegg via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Sat Mar 10 17:32:48 PST 2018
    
    
  
sbc100 added a comment.
You are right, the imported globals are never used.
And yes this was as first step to solving https://github.com/WebAssembly/tool-conventions/issues/48.
And yes I agree we probably don't want to land this without the imports actually being used.
And yes, sadly we do have use case for this, in emscripten.  I injects the addresses of globals in this way.. something I only just discovered :(
Repository:
  rLLD LLVM Linker
https://reviews.llvm.org/D44348
    
    
More information about the llvm-commits
mailing list