[PATCH] D44323: [WebAssembly] Remove a second parameter from toString().

[Nicholas Wilson via Phabricator via llvm-commits]

ncw added inline comments.


================
Comment at: wasm/Symbols.cpp:186
     if (Optional<std::string> S = demangleItanium(Sym.getName()))
-      return QuoteDemangled ? ("`" + *S + "'") : *S;
   return Sym.getName();
----------------
ruiu wrote:
> sbc100 wrote:
> > I'm ok with this change, but I like this feature, so I would like to bring it back in some form, perhaps for all backends.  Otherwise it makes very long C++ symbols very hard to distinguish from the rest of the error/message.
> > 
> > This is what gnu ld does I believe.
> If you need this, please do it all the times, or do it on the caller side. I want to keep toString() an unary function that converts a given object to its (only) string representation.
I'll sort this out by updating D44316 - it was my mess, sorry.

Fix: toString will always quote unmangled names, and check `Config->Demangle`. I'll add another helper that doesn't check `Config->Demangle` and doesn't quote, for use in creating the "Name" section.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44323