[llvm] r327100 - Attempt to fix vecreduce-propagate-sd-flags.ll test.

[via llvm-commits]

On 2018-03-09 21:17, Galina Kistanova via llvm-commits wrote:
> Hello Matt,
> 
> It looks like this commit broke few our builders:
> 
> http://lab.llvm.org:8011/builders/clang-with-lto-ubuntu/builds/7567
> http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu
> 
> UNRESOLVED: LLVM :: CodeGen/AArch64/vecreduce-propagate-sd-flags.s
> (16828 of 37668)
> ******************** TEST 'LLVM ::
> CodeGen/AArch64/vecreduce-propagate-sd-flags.s' FAILED
> ********************
> 
> Please have a look?
> 
> Thanks
> 
> Galina
> 
> On Thu, Mar 8, 2018 at 6:04 PM, Matt Morehouse via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> 
>> Author: morehouse
>> Date: Thu Mar  8 18:04:30 2018
>> New Revision: 327100
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=327100&view=rev [1]
>> Log:
>> Attempt to fix vecreduce-propagate-sd-flags.ll test.
>> 
>> Buildbots have been failing since r327079.
>> 
>> Modified:
>> llvm/trunk/test/CodeGen/AArch64/vecreduce-propagate-sd-flags.ll
>> 
>> Modified:
>> llvm/trunk/test/CodeGen/AArch64/vecreduce-propagate-sd-flags.ll
>> URL:
>> 
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AArch64/vecreduce-propagate-sd-flags.ll?rev=327100&r1=327099&r2=327100&view=diff
>> [2]
>> 
> ==============================================================================
>> --- llvm/trunk/test/CodeGen/AArch64/vecreduce-propagate-sd-flags.ll
>> (original)
>> +++ llvm/trunk/test/CodeGen/AArch64/vecreduce-propagate-sd-flags.ll
>> Thu Mar  8 18:04:30 2018
>> @@ -1,6 +1,6 @@
>> ; REQUIRES: arm-registered-target
>> ; REQUIRES: asserts
>> -; RUN: llc %s -debug-only=legalize-types 2>&1 | FileCheck %s
>> +; RUN: llc -o /dev/null %s -debug-only=legalize-types 2>&1 |
>> FileCheck %s
>> 
>> ; This test check that when v4f64 gets broken down to two v2f64 it
>> maintains
>> ; the "nnan" flags.
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits [3]
> 
> 
> 
> Links:
> ------
> [1] http://llvm.org/viewvc/llvm-project?rev=327100&view=rev
> [2]
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AArch64/vecreduce-propagate-sd-flags.ll?rev=327100&r1=327099&r2=327100&view=diff
> [3] http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
Hi Galina,

Actually this failure was caused by commit r327079 
(https://reviews.llvm.org/rL327079) which commits this patch 
(https://reviews.llvm.org/D44245).

The test I had ran llc without passing specifying location, this caused 
it to  output the resulting assembly file
in the test directory, the buildbot later on tries to run the *.s file 
as a test and fails. Matt's commit fixes the problem.

According to @nemanjai, removing  the asm file and applying Matt's fix 
should fix the problem.

I hope this fixes the problem for you and I am sorry about this.

Sameer AbuAsal
Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.