[PATCH] D44331: [WebAssembly] Add test for imported ctor and fix indexing bug found
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 9 20:14:59 PST 2018
sbc100 added inline comments.
================
Comment at: wasm/Writer.cpp:664
else
- ++NumImportedGlobals;
+ Sym->setOutputIndex(NumImportedGlobals++);
}
----------------
Do the tests now check for this? (i.e. if you revert this part of the change will the test fail?)
Maybe be worth splitting this off as a separate bug fix?
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D44331
More information about the llvm-commits
mailing list