[PATCH] D44334: Go back to sometimes assuming intristics are local
    Chandler Carruth via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Fri Mar  9 17:22:42 PST 2018
    
    
  
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for tracking this down Rafael! (nit pick below, not critical)
================
Comment at: lib/Target/TargetMachine.cpp:121
+  // local since the linker can convert some direct access to access via plt.
+  if (M.getRtLibUseGOT() && GV == nullptr)
+    return false;
----------------
Maybe just `!GV` here for consistency with the rest of the code?
https://reviews.llvm.org/D44334
    
    
More information about the llvm-commits
mailing list