[compiler-rt] r327185 - [asan] Clean up the REQUIRES of `asan/TestCases/strcat-overlap.cc`

[Dan Liew via llvm-commits]

Author: delcypher
Date: Fri Mar  9 15:12:32 2018
New Revision: 327185

URL: http://llvm.org/viewvc/llvm-project?rev=327185&view=rev
Log:
[asan] Clean up the REQUIRES of `asan/TestCases/strcat-overlap.cc`
by explicitly listing where we expect this test to work.

Because this test invokes undefined behaviour all sorts of things
can happen (e.g. crash, or on some bots asan manages to catch
something). The test seems to pass okay on Darwin (x86_64/x86_64/i386)
and on Linux (x86_64/i386) so explicitly require one of these platforms
to run the test.

Modified:
    compiler-rt/trunk/test/asan/TestCases/strcat-overlap.cc

Modified: compiler-rt/trunk/test/asan/TestCases/strcat-overlap.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/strcat-overlap.cc?rev=327185&r1=327184&r2=327185&view=diff
==============================================================================
--- compiler-rt/trunk/test/asan/TestCases/strcat-overlap.cc (original)
+++ compiler-rt/trunk/test/asan/TestCases/strcat-overlap.cc Fri Mar  9 15:12:32 2018
@@ -26,7 +26,11 @@
 // RUN: echo "interceptor_name:strcat" > %t.supp
 // RUN: %env_asan_opts=suppressions='"%t.supp"' %run %t
 
-// REQUIRES: (target-is-x86_64 || target-is-x86_64h) && !ios
+// This test when run with suppressions invokes undefined
+// behavior which can cause all sorts of bad things to happen
+// depending on how strcat() is implemented. For now only run
+// on platforms where we know the test passes.
+// REQUIRES: x86_64h-darwin || x86_64-darwin || i386-darwin || x86_64-linux || i386-linux
 // UNSUPPORTED: win32
 // UNSUPPORTED: android