[PATCH] D44324: [TwoAddressInstructionPass] Improve tryInstructionCommute X86 FMA and vpternlog instructions

[Vyacheslav Klochkov via Phabricator via llvm-commits]

v_klochkov accepted this revision.
v_klochkov added a comment.
This revision is now accepted and ready to land.

Hi Craig,
This change-set looks good to me.
-Vyacheslav



================
Comment at: lib/CodeGen/TwoAddressInstructionPass.cpp:1386
           tryInstructionTransform(NewMI, mi, NewSrcIdx, NewDstIdx, Dist, true);
         (void)TransformResult;
         assert(!TransformResult &&
----------------
I was looking for some potential problems on the caller side of the routine you changed; have not found anything interesting/wrong there, but noticed this odd line. 
If it also seems redundant/nop to you and if you decide removing this line, then I am Ok with that.


https://reviews.llvm.org/D44324