[PATCH] D44328: Support embedding natvis files in PDBs.

[Reid Kleckner via Phabricator via llvm-commits]

rnk requested changes to this revision.
rnk added inline comments.
This revision now requires changes to proceed.


================
Comment at: lld/COFF/PDB.cpp:984
+    std::string StreamName = (Twine("/src/files/") + File).str();
+    ExitOnErr(Builder.addNamedStream(StreamName, NatvisData->getBuffer()));
+  }
----------------
Hm, won't this make a UAF? The file is allocated here, we pass in a stringref, and nobody keeps the file mapping alive.


https://reviews.llvm.org/D44328