[PATCH] D44322: [AMDGPU] Fix lowering enqueue kernel when kernel has no name

Yaxun Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 9 14:18:03 PST 2018


yaxunl marked an inline comment as done.
yaxunl added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUOpenCLEnqueuedBlockLowering.cpp:99
+      if (!F.hasName())
+        F.setName(Twine("__amdgpu_enqueued_kernel") + Twine(Count++));
+      auto RuntimeHandle = (F.getName() + "_runtime_handle").str();
----------------
arsenm wrote:
> Should this use getNameWithPrefix instead?
Yes. It is better to use the standard way. Will do.


https://reviews.llvm.org/D44322





More information about the llvm-commits mailing list