[PATCH] D39869: [Inliner] Inline through indirect call sites having !callees metadata
Matthew Simpson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 9 13:22:25 PST 2018
mssimpso added a comment.
Hi David,
I'd like to get back to this patch soon. Have you given the previous comments anymore thought? We had started to discuss whether the transformation should be done inside the inliner or the indirect call promotion pass. An advantage of letting the inliner do the promotion is that the inline cost, which is used to determine if an indirect call should be promoted, is known. If promotion is done outside the inliner, the cost would only be an estimate. An advantage of moving the transformation to the indirect call promotion pass may be that it is a better conceptual fit within that pass. On the other hand, it is not a pgo-driven transformation. A third possibility would be a separate pass. Would do you think?
Repository:
rL LLVM
https://reviews.llvm.org/D39869
More information about the llvm-commits
mailing list