[PATCH] D44274: Object: Fix handling of @@@ in .symver directive

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/lib/Object/RecordStreamer.cpp:149
+  if (!Split.second.empty() && !Split.second.startswith("@")) {
+    // Special processing for "@@@" according
+    // https://sourceware.org/binutils/docs/as/Symver.html
----------------
I think you need to defer this processing until the end to handle the case where a `.symver` appears before an inline asm definition.


================
Comment at: llvm/lib/Object/RecordStreamer.cpp:174
+      }
+      IsDefined = GV && GV->isDefinitionExact();
+    }
----------------
This line should probably be `IsDefined = GV && !GV->isDeclarationForLinker()`.


https://reviews.llvm.org/D44274