[PATCH] D44276: Object: Move attribute calculation into RecordStreamer. NFC
Rafael Avila de Espindola via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 9 10:56:46 PST 2018
espindola added inline comments.
================
Comment at: llvm/lib/Object/RecordStreamer.cpp:24
+ SmallString<64> MangledName;
+ auto GetMangledName = [&](const GlobalValue &GV) {
+ if (!GV.hasName())
----------------
Starting the name with Get suggests this return the name. Maybe RecordMangledName?
================
Comment at: llvm/lib/Object/RecordStreamer.cpp:33
+ };
+ for (const Function &F : M)
+ GetMangledName(F);
----------------
While you are here, could you add Ifuncs? Probably the best way is to just use global_values().
================
Comment at: llvm/lib/Object/RecordStreamer.h:71
+ // they alias with.
+ void EmitSymverAttributes();
};
----------------
Start new functions with a lowercase letter.
https://reviews.llvm.org/D44276
More information about the llvm-commits
mailing list