[PATCH] D44198: TableGen: Only fold when some operand made resolve progress

[Artem Belevich via Phabricator via llvm-commits]

tra added inline comments.


================
Comment at: lib/TableGen/TGParser.cpp:1967
+        if (!LHS) {
+          Error(PasteLoc, "LHS of paste not typed after cast!");
+          return nullptr;
----------------
The error message could be more specific about the failure.
Perhaps it should do something along the lines of `"can't cast " + LHS->getAsString()+ "to string"`. 


================
Comment at: lib/TableGen/TGParser.cpp:2000
+          if (!RHS) {
+            Error(PasteLoc, "RHS of paste not typed after cast!");
+            return nullptr;
----------------
Same here.


Repository:
  rL LLVM

https://reviews.llvm.org/D44198