[PATCH] D44310: Only create an alias for @@@ once we know if it should use @ or @@

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 9 10:25:10 PST 2018


vitalybuka accepted this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.

LGTM, but this patch does not yet resolves the test from: https://reviews.llvm.org/D44274 . Is this expected?



================
Comment at: lib/MC/ELFObjectWriter.cpp:402
+    if (Rest.startswith("@@@"))
+      Tail = Symbol.isUndefined() ? Rest.substr(2) : Rest.substr(1);
+
----------------
```
= Rest.substr(Symbol.isUndefined() ? 2 : 1);
```


https://reviews.llvm.org/D44310





More information about the llvm-commits mailing list