[PATCH] D43687: Improve merging of debug locations (fixes PR 36410)

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 9 08:56:18 PST 2018


aprantl added a comment.

> What exactly are you doing to reproduce this?

I'm running the crash reproducer through delta now...

> OK. Maybe it is indeed a better choice to *not* merge dbg.value intrinsics, but just move over both sets from both sides of the "if" unchanged. In fact, if you have dbg.value intrinsics for *different* variables, they are currently just deleted -- moving them over should keep the (correct) information that *both* those variables now have the specfied value at the new location ...

Keeping both intrinsics is always a safe choice.


Repository:
  rL LLVM

https://reviews.llvm.org/D43687





More information about the llvm-commits mailing list