[PATCH] D44290: Handle mixed-OS paths in DWARF reader

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 9 08:51:38 PST 2018


aprantl added a comment.

This will also need a testcase.



================
Comment at: lib/DebugInfo/DWARF/DWARFDebugLine.cpp:956
 
+static bool isPathAbsoluteOnWindowsOrPosix(const Twine &Path) {
+  // Debug info can contain paths from any OS, not necessarily
----------------
Shouldn't this function be provided in libSupport? For example, by adding a new enumerator sys::path::Style::any ?


https://reviews.llvm.org/D44290





More information about the llvm-commits mailing list