[PATCH] D44201: [WebAssembly] Disallow weak undefined globals in the object format
Nicholas Wilson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 9 08:33:21 PST 2018
ncw added inline comments.
================
Comment at: lib/Object/WasmObjectFile.cpp:426
+ if (!IsDefined &&
+ (Info.Flags & wasm::WASM_SYMBOL_BINDING_MASK) ==
+ wasm::WASM_SYMBOL_BINDING_WEAK)
----------------
sbc100 wrote:
> Add and test for this error maybe?
>
> Should the error be more specific?
>
> Do we also want to add an error to MC/WasmObjectWriter.cpp?
Done, on all three counts.
Repository:
rL LLVM
https://reviews.llvm.org/D44201
More information about the llvm-commits
mailing list