[PATCH] D44308: [ConstantFold] fp_binop AnyConstant, undef --> NaN

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 9 08:31:33 PST 2018


spatel added inline comments.


================
Comment at: test/CodeGen/AMDGPU/skip-if-dead.ll:279-281
+define amdgpu_ps void @phi_use_def_before_kill(float %x) #0 {
 bb:
+  %tmp = fadd float %x, 1.000000e+00
----------------
arsenm wrote:
> This is potentially a bad test change because this is now a divergent branch. Adding inreg to the parameter should fix it
Thanks - I didn't understand what was happening there. I'll fix it and remove this test from the patch.


https://reviews.llvm.org/D44308





More information about the llvm-commits mailing list