[PATCH] D39245: [ADT] Shuffle containers before sorting to uncover non-deterministic behavior

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 9 06:06:33 PST 2018


RKSimon accepted this revision.
RKSimon added a comment.

LGTM, with one minor



================
Comment at: include/llvm/ADT/STLExtras.h:794
 
+// Provide wrappers to std::sort which shuffle the elements before sorting.
+template <typename IteratorTy>
----------------
Please expand this a little:
```
// Provide wrappers to std::sort which shuffle the elements before sorting
// to help uncover non-deterministic behavior (PR35135).
```




Repository:
  rL LLVM

https://reviews.llvm.org/D39245





More information about the llvm-commits mailing list