[PATCH] D43314: [lit] - Allow 1 test to report multiple micro-test results to provide support for microbenchmarks.

[Renato Golin via Phabricator via llvm-commits]

rengolin accepted this revision.
rengolin added a comment.

LGTM with the sorting comment. Thanks!



================
Comment at: utils/lit/lit/main.py:130
+            for key, micro_test in test.result.microResults.items():
+                micro_full_name = test.getFullName()[:-5] + '/' + key + ".test"
+
----------------
rengolin wrote:
> homerdin wrote:
> > homerdin wrote:
> > > rengolin wrote:
> > > > What's with the [:-5] ?
> > > I changed the way I build the name to be clearer.  Was using [:-5] (.test) to expand the parent test name with the micro test name before ".test" 
> > Realizing this is incorrect as it only works with ".test" files.  Need a safer way to expand the test name.
> regular expression would do nicely
Don't you need to sort these ones, too?


https://reviews.llvm.org/D43314