[PATCH] D43501: [lit] Implement 'cat' command for internal shell

[Chamal De Silva via Phabricator via llvm-commits]

chamalsl marked 4 inline comments as done.
chamalsl added a comment.

I do not have commit access.
Can you please commit this change.



================
Comment at: utils/lit/lit/TestRunner.py:816
         try:
-            procs.append(subprocess.Popen(args, cwd=cmd_shenv.cwd,
-                                          executable = executable,
+            tempArgs = None;
+            if isBuiltInCommand == True:
----------------
rnk wrote:
> You don't need `tempArgs` and `tempExecutable`.
Did the change. But is it OK to modify original 'args' list instead of a temporary list?
Can there be another place that needs the original 'args' list?


https://reviews.llvm.org/D43501