[PATCH] D44144: [LNT] Always display Profile button when having a profile.

Martin Liška via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 9 03:07:50 PST 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rL327114: Always display Profile button when having a profile. (authored by marxin, committed by ).
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D44144?vs=137156&id=137717#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D44144

Files:
  lnt/trunk/lnt/server/ui/templates/layout.html
  lnt/trunk/lnt/server/ui/templates/utils.html


Index: lnt/trunk/lnt/server/ui/templates/utils.html
===================================================================
--- lnt/trunk/lnt/server/ui/templates/utils.html
+++ lnt/trunk/lnt/server/ui/templates/utils.html
@@ -37,19 +37,19 @@
     {% if compare_profile and profile %}
 
       <a href="{{ v4_url_for('.v4_profile_fwd2', run1_id=run_id, run2_id=compare_run_id, testid=test_id) }}"
-         class="profile-btn btn btn-mini pull-right">Profile<i class="icon-eye-open"></i></a>
+         class="btn btn-mini pull-right">Profile <i class="icon-eye-open"></i></a>
  
     {% elif profile %}
       
       <a href="{{ v4_url_for('.v4_profile_fwd', run1_id=run_id, testid=test_id) }}"
-         class="profile-btn btn btn-mni pull-right profile-but-no-prev" data-toggle="tooltip"
-         title="This run has a profile, but the run being compared to does not">Profile<i class="icon-exclamation-sign"></i></a>
+         class="btn btn-mni pull-right profile-but-no-prev" data-toggle="tooltip"
+         title="This run has a profile, but the run being compared to does not">Profile <i class="icon-exclamation-sign"></i></a>
       
     {% elif compare_profile %}
       
       <a href="{{ v4_url_for('.v4_profile_fwd', run1_id=compare_run_id, testid=test_id) }}"
-         class="profile-btn bt btn-mini pull-right profile-prev-only" data-toggle="tooltip"
-         title="This run does not have a profile, but the run being compared to does">Profile<i class="icon-exclamation-sign"></i></a>
+         class="bt btn-mini pull-right profile-prev-only" data-toggle="tooltip"
+         title="This run does not have a profile, but the run being compared to does">Profile <i class="icon-exclamation-sign"></i></a>
       
     {% endif %}
   {% endif %}
Index: lnt/trunk/lnt/server/ui/templates/layout.html
===================================================================
--- lnt/trunk/lnt/server/ui/templates/layout.html
+++ lnt/trunk/lnt/server/ui/templates/layout.html
@@ -81,16 +81,6 @@
       }
     }
 
-    /* Make profile buttons invisible by default */
-    tr .profile-btn {
-      visibility: hidden;
-    }
-
-    /* But appear when their parent table rows are hovered. */
-    tr:hover .profile-btn {
-      visibility: visible;
-    }
-
     /* Floating headers can't have clear backgrounds. */
     .floating_header thead {
         background-color: #FFFFFF;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44144.137717.patch
Type: text/x-patch
Size: 2382 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180309/7c1e29d1/attachment.bin>


More information about the llvm-commits mailing list