[PATCH] D44283: Don't treat .symver as a regular alias definition

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 8 19:14:05 PST 2018


Vitaly Buka via Phabricator via llvm-commits
<llvm-commits at lists.llvm.org> writes:

> vitalybuka added inline comments.
>
>
> ================
> Comment at: lib/MC/MCParser/ELFAsmParser.cpp:774
>    MCSymbol *Sym = getContext().getOrCreateSymbol(Name);
> -  const MCExpr *Value = MCSymbolRefExpr::create(Sym, getContext());
> -
> -  getStreamer().EmitAssignment(Alias, Value);
>    getStreamer().emitELFSymverDirective(Alias, Sym);
>    return false;
> ----------------
> Can we still pass AliasName instead of created Alias ?

That is what I intend to do in a followup patch. That way we only create
the symbol once we know if @@@ should be a @@ or a @.

Cheers,
Rafael


More information about the llvm-commits mailing list