[PATCH] D44283: Don't treat .symver as a regular alias definition

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: lib/MC/MCParser/ELFAsmParser.cpp:774
   MCSymbol *Sym = getContext().getOrCreateSymbol(Name);
-  const MCExpr *Value = MCSymbolRefExpr::create(Sym, getContext());
-
-  getStreamer().EmitAssignment(Alias, Value);
   getStreamer().emitELFSymverDirective(Alias, Sym);
   return false;
----------------
vitalybuka wrote:
> vitalybuka wrote:
> > pcc wrote:
> > > vitalybuka wrote:
> > > > Can we still pass AliasName instead of created Alias ?
> > > > 
> > > > 
> > > Most clients will want to consume the MCSymbol, so it seems a little simpler to create it here.
> > Then I am sure when to replace @@@ with @ or @@
> I can e.g. discard already created MCSymbol and replace with new one
Either that or see if we can avoid creating the new MCSymbol at all.


https://reviews.llvm.org/D44283