[PATCH] D44276: Object: Move attribute calculation into RecordStreamer. NFC
Rafael Avila de Espindola via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 8 17:36:27 PST 2018
espindola added inline comments.
================
Comment at: llvm/include/llvm/MC/MCStreamer.h:530
/// \param Aliasee - The aliased symbol (i.e. "_start")
- virtual void emitELFSymverDirective(MCSymbol *Alias, const MCSymbol *Aliasee);
+ virtual MCSymbol *createELFSymverAlias(StringRef AliasName,
+ const MCSymbol *Aliasee);
----------------
I think we have to keep an emit method for this. See https://reviews.llvm.org/D44283.
I am sorry for the current state that symver handling is at. It is basically an 7 year old hack that never got cleaned up.
https://reviews.llvm.org/D44276
More information about the llvm-commits
mailing list