[PATCH] D42453: Use branch funnels for virtual calls when retpoline mitigation is enabled.

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

This looks really, really nice. Thanks for all the hard work here!



================
Comment at: llvm/include/llvm/Target/Target.td:1146
+  let InOperandList = (ins variable_ops);
+  let AsmString = "";
+  let hasSideEffects = 1;
----------------
pcc wrote:
> chandlerc wrote:
> > Does it make sense to put a comment string here to make reading the dump of MI easier? (I'm not sure, genuine question here.)
> No, the MI dump already says "ICALL_BRANCH_FUNNEL". This string is used in the asm output for instructions that survive until MC, and this one doesn't.
Ah, nice. Thanks for checking!


https://reviews.llvm.org/D42453