[PATCH] D44128: [GISel]: Add helpers for easy building G_FCONSTANT along with matchers

[Volkan Keles via Phabricator via llvm-commits]

volkan accepted this revision.
volkan added a comment.
This revision is now accepted and ready to land.

LGTM. Thank you Aditya.



================
Comment at: include/llvm/CodeGen/GlobalISel/Utils.h:38
+class APFloat;
+class LLT;
 
----------------
I think fltSemantics and LLT are no longer required. Could you remove them before committing?


================
Comment at: lib/CodeGen/GlobalISel/MachineIRBuilder.cpp:291
+  LLT DstTy = MRI->getType(Res);
+  assert(!DstTy.isValid() || (DstTy.getSizeInBits() >= Ty.getSizeInBits()) &&
+                                 "DstReg not large enough for Ty");
----------------
aditya_nandakumar wrote:
> volkan wrote:
> > Could you check this in MachineVerifier as well?
> I can do this in a separate commit as this is only adding builder helpers vs adding verifier + fixing tests.
That works for me.


https://reviews.llvm.org/D44128