[PATCH] D44224: [llvm-objdump] Support disassembling by symbol name

[Rafael Avila de Espindola via llvm-commits]

Rafael Auler via Phabricator <reviews at reviews.llvm.org> writes:

> +  if (!DisassembleFunctions.empty())
> +    DisasmFuncsSet.insert(DisassembleFunctions.begin(),
> +                          DisassembleFunctions.end());

I don't think you need the if:

    DisasmFuncsSet.insert(DisassembleFunctions.begin(),
                          DisassembleFunctions.end());

Will do nothing if DisassembleFunctions is empty.

LGTM with that.

Cheers,
Rafael