[PATCH] D42447: [LV][VPlan] Detect outer loops for explicit vectorization.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 8 14:07:35 PST 2018


fhahn added a comment.

>   Outer loop detection: only outer loops annotated with explicit vectorization hints, including the vector length, are collected for outer loop vectorization. This includes outer loops annotated with #pragma omp simd simdlen(#) or #pragma clang vectorize(enable) vectorize_width(#)*.

If I understand correctly, this limitation is due to the fact that VPlan based cost-modelling is not implemented yet, right? I think for testing, it would useful to have an option to process all outer loops. The legality checks should filter out any unsupported loops and this way we could test the VPlan native code path on a much wider range of loops. I think it also would be great if we would have a bot that runs at least the test-suite with VPlan native to discover regressions.



================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:29
 //
+// There is a development effort going on to migrate loop vectorizer to the
+// VPlan infrastructure and to introduce outer loop vectorization support (see
----------------
Is it worth mentioning docs/Proposal/VectorizationPlan.rst as well?


https://reviews.llvm.org/D42447





More information about the llvm-commits mailing list