[PATCH] D39906: [InstCombine] Allowing GEP Instructions with loop Invariant operands to combine

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

The 175.vpr result looks bad.

I'm still not convinced this is the right approach; if you look at the testcase as a reassociation problem, you can optimize it without duplicating code.



================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:1726
+        if (Sum == nullptr)
+          return nullptr;
+      }
----------------
CreateAdd (still) can't return null.


https://reviews.llvm.org/D39906