[PATCH] D44176: [mips] Add support for CRC ASE

Vladimir Stefanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 8 11:59:06 PST 2018


vstefanovic marked 15 inline comments as done.
vstefanovic added inline comments.


================
Comment at: test/MC/Mips/crc/invalid.s:1
+# Instructions that are invalid.
+#
----------------
sdardis wrote:
> Can you also add an invalid-wrong-isa.s test file which uses .set mipsXX * .set micromips to show that we correctly reject the instruction for pre-R6 ISAs?
I have invalid-wrong-isa.s locally now, if we want to add it later.


Repository:
  rL LLVM

https://reviews.llvm.org/D44176





More information about the llvm-commits mailing list