[PATCH] D43687: Improve merging of debug locations (fixes PR 36410)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 8 11:40:55 PST 2018


Yeah, I still need to look more closely at this - my hunch/feeling is that,
while/if this approach is necessary for dbg.value intrinsics, it'd still
produce wrong or at least suboptimal locations in general. :/ (& I'm not
even sure it's the best thing for the dbg.values either... not sure what
should be done about them - perhaps they shouldn't be merged, instead
duplicated & keep their respective locations)

On Thu, Mar 8, 2018 at 9:15 AM Adrian Prantl via Phabricator <
reviews at reviews.llvm.org> wrote:

> aprantl added a comment.
>
> Ping! David, have all your concerns been addressed, or do we need to
> iterate some more on this?
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D43687
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180308/abaf2dde/attachment.html>


More information about the llvm-commits mailing list