[PATCH] D44230: Add a ReadWriteMemoryBuffer class that can map an input file for modification

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

In https://reviews.llvm.org/D44230#1031111, @labath wrote:

> - Right now the F_NoTrunc flag is ignored if one specifies F_Append (we always treat it as present). However, the Append&&!NoTrunc combination also has a well defined (although not extremely useful) semantics. I wonder if it wouldn't be clearer to make the two completely independent. This would require adding F_NoTrunc to every existing call that specifies F_Append, but I currently count only about half a dozen of those..


It might be clearer, to someone reading the code, but probably less obvious to someone writing new code.  People familiar with a posix-like api expect the current `F_Append` semantics, so I think we should make those assumptions continue to hold.

I'll work on a test.


https://reviews.llvm.org/D44230