[PATCH] D42960: [ELF] Add .eh_frame pieces to map file

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 8 10:45:09 PST 2018


ruiu added a comment.

I don't think omitting `+0x<hex>` only when it is `+0x0` doesn't make much sense. It is better to always print out an offset regardless of its value. That also makes it easy to parse by machine.

Does alignment make sense? I think that each section has an alignment, but each piece in an .eh_frame doesn't have a notion of an alignment. So I think it isn't correct to show a section alignment as a piece alignment.


https://reviews.llvm.org/D42960





More information about the llvm-commits mailing list