[PATCH] D44004: [ELF] - Show data and assignment commands in the map file.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In https://reviews.llvm.org/D44004#1031551, @rafael wrote:

> > ruiu wrote:
> > 
> >> FirstTok and LastTok are not tokens but positions, so you should avoid "Tok".
> > 
> > Not sure what is wrong here honestly. 
> >  I think `first` and `last` can be both adjectives and nouns. I meant that they are adjectives describing the
> >  tokens and hence they are not positions here I think.
> >  I renamed to `First`/`Last` though as such naming is also OK for me.
>
> I think Rui's objection is that one would expect a *Tok variable to be
>  a StringRef. What you have are token number/indexes. I am ok with
>  First/Last, but maybe FirstTokI/LastTokI would be best.
>
> Cheers,
> Rafael


Ah, thanks, now I see my mistake, I misunderstood initial objection. 
Both ways of new namings look OK to me I think.


https://reviews.llvm.org/D44004