[PATCH] D44224: [llvm-objdump] Support disassembling by symbol name

[Jonas Devlieghere via llvm-commits]

> On Mar 8, 2018, at 5:19 PM, Rafael Avila de Espindola <rafael.espindola at gmail.com> wrote:
> 
> Rafael Auler <rafaelauler at fb.com> writes:
> 
>> This is static because the function DisassembleObject potentially runs multiple times. So the static is to avoid re-creating the same set for each object, and it's also why it checks if it is empty.
> 
> OK, that is a bit unusual. Please move the set initialization just
> before
> 
>  llvm::for_each(InputFilenames, DumpInput);
> 
> So that it can be done only once by more conventional means. I am OK
> with the set being global.

+1, that would even be better than what I suggested.  

> Cheers,
> Rafael