[PATCH] D44018: [COFF] Make the DOS stub a real DOS program

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

In https://reviews.llvm.org/D44018#1030009, @ruiu wrote:

> LGTM


Thanks! I'll make the change and commit.



================
Comment at: COFF/Writer.cpp:689
 template <typename PEHeaderTy> void Writer::writeHeader() {
-  // Write DOS stub
+  // Write DOS header.
   uint8_t *Buf = Buffer->getBufferStart();
----------------
ruiu wrote:
> It's perhaps better to expand this comment a bit so that the thing we are doing here is not important to understand the linker itself -- it's just a small DOS program at beginning of every PE/COFF executable to help DOS 2.0 (!) users that the program needs Windows.
I've expanded the comment to explain.


https://reviews.llvm.org/D44018