[PATCH] D44187: Simplify LazyobjFile and readElfSymbols.

[Rafael Ávila de Espíndola via Phabricator via llvm-commits]

rafael added a comment.

Rui Ueyama via Phabricator via llvm-commits
<llvm-commits at lists.llvm.org> writes:

> -template <class ELFT> std::vector<StringRef> LazyObjFile::getElfSymbols() {
> 
> - typedef typename ELFT::Shdr Elf_Shdr;
> - typedef typename ELFT::Sym Elf_Sym;
> - typedef typename ELFT::SymRange Elf_Sym_Range; +template <class ELFT> void LazyObjFile::addElfSymbols() { +  StringRef ObjName = MB.getBufferIdentifier(); +  ELFFile<ELFT> Obj = check(ELFFile<ELFT>::create(MB.getBuffer())); +  ArrayRef<typename ELFT::Shdr> Sections = CHECK(Obj.sections(), ObjName);

Why change CHECK(..., this) to CHECK(..., ObjName)?

LGTM with that.

Cheers,
Rafael


Repository:
  rL LLVM

https://reviews.llvm.org/D44187