[PATCH] D44004: [ELF] - Show data and assignment commands in the map file.

[Rafael Ávila de Espíndola via Phabricator via llvm-commits]

rafael added a comment.

George Rimar via Phabricator via llvm-commits
<llvm-commits at lists.llvm.org> writes:

> +# RUN: ld.lld -o %t %t.o -Map=%t.map --script %s
>  +# RUN: FileCheck -strict-whitespace %s < %t.map

Why do you need -strict-whitespace? The fact that you have a newline in
0x123 * (1+1) should be sufficient, no?

> +  // Keeps string representing the expression. Used when printing map file.
>  +  StringRef StringView;
>  +
>  +  unsigned Offset;
>  +  unsigned Size;

Add a comment about Offset and Size. Looking at a SymbolAssignment one
could assume Offset is the offset in a section and Size the size of the
elf symbol.

Cheers,
Rafael


https://reviews.llvm.org/D44004