[PATCH] D43751: [cmake] Append -Wl, -rpath-link conditionally to GNULD

Ed Maste via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 7 20:18:20 PST 2018


emaste added a comment.

In https://reviews.llvm.org/D43751#1030947, @krytarowski wrote:

> ld(1) might accept -z origin, but why do we want it for other OSes? I don't see it used in the NetBSD dynamic ELF loader. `DF_ORIGIN` is just defined but not used by anything.


It was largely an aside, just pointing out that we could eliminate an OS-specific special case.

> FreeBSD seems to be hypercorrect in terms of ELF handling, other OSes don't care that much.

In fact setting `-z origin` here on (current) versions of FreeBSD serves no purpose, but it also doesn't hurt anything.


Repository:
  rL LLVM

https://reviews.llvm.org/D43751





More information about the llvm-commits mailing list