[PATCH] D41465: [LTO] Support filtering by hotness threshold

[Adam Nemet via llvm-commits]

Is this from a bot?  A bit more info would be helpful. 

> On Mar 7, 2018, at 5:17 PM, Bob Haarman via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> inglorion added a comment.
> 
> I reverted this commit in r326975 because it failed ThinLTO/X86/diagnostic-handler-remarks-with-hotness.ll.
> 
>  FAIL: LLVM :: ThinLTO/X86/diagnostic-handler-remarks-with-hotness.ll (1 of 1)
>  ******************** TEST 'LLVM :: ThinLTO/X86/diagnostic-handler-remarks-with-hotness.ll' FAILED ********************
>  Script:
>  --
>  /usr/local/google/home/inglorion/clang/bin/opt -module-summary /usr/local/google/home/inglorion/llvm/llvm/test/ThinLTO/X86/diagnostic-handle
>  r-remarks-with-hotness.ll -o /usr/local/google/home/inglorion/clang/test/ThinLTO/X86/Output/diagnostic-handler-remarks-with-hotness.ll.tmp1.bc
>  /usr/local/google/home/inglorion/clang/bin/opt -module-summary /usr/local/google/home/inglorion/llvm/llvm/test/ThinLTO/X86/Inputs/diagnostic
>  -handler-remarks.ll -o /usr/local/google/home/inglorion/clang/test/ThinLTO/X86/Output/diagnostic-handler-remarks-with-hotness.ll.tmp2.bc
>  /usr/local/google/home/inglorion/clang/bin/llvm-lto -thinlto-action=run           -lto-pass-remarks-output=/usr/local/google/home/inglorion/clang/test/ThinLTO/X86/Output/diagnostic-handler-remarks-with-hotness.ll.tmp-no-th.yaml           -lto-pass-remarks-with-hotness           -
>  exported-symbol _func2           -exported-symbol _main /usr/local/google/home/inglorion/clang/test/ThinLTO/X86/Output/diagnostic-handler-re
>  marks-with-hotness.ll.tmp1.bc /usr/local/google/home/inglorion/clang/test/ThinLTO/X86/Output/diagnostic-handler-remarks-with-hotness.ll.tmp2.bc 2>&1 |      /usr/local/google/home/inglorion/clang/bin/FileCheck /usr/local/google/home/inglorion/llvm/llvm/test/ThinLTO/X86/diagnostic-
>  handler-remarks-with-hotness.ll -allow-empty
>  /usr/local/google/home/inglorion/clang/bin/llvm-lto -thinlto-action=run           -lto-pass-remarks-output=/usr/local/google/home/inglorion/clang/test/ThinLTO/X86/Output/diagnostic-handler-remarks-with-hotness.ll.tmp-low-th.yaml           -lto-pass-remarks-with-hotness
>  -lto-pass-remarks-hotness-threshold=20           -exported-symbol _func2           -exported-symbol _main /usr/local/google/home/inglorion/c
>  lang/test/ThinLTO/X86/Output/diagnostic-handler-remarks-with-hotness.ll.tmp1.bc /usr/local/google/home/inglorion/clang/test/ThinLTO/X86/Outp
>  ut/diagnostic-handler-remarks-with-hotness.ll.tmp2.bc 2>&1 |  /usr/local/google/home/inglorion/clang/bin/llvm-lto -thinlto-action=run
>      -lto-pass-remarks-output=/usr/local/google/home/inglorion/clang/test/ThinLTO/X86/Output/diagnostic-handler-remarks-with-hotness.ll.tmp-h
>  igh-th.yaml           -lto-pass-remarks-with-hotness           -lto-pass-remarks-hotness-threshold=100           -exported-symbol _func2
>         -exported-symbol _main /usr/local/google/home/inglorion/clang/test/ThinLTO/X86/Output/diagnostic-handler-remarks-with-hotness.ll.tmp1
>  .bc /usr/local/google/home/inglorion/clang/test/ThinLTO/X86/Output/diagnostic-handler-remarks-with-hotness.ll.tmp2.bc 2>&1 |  cat /usr/local
>  /google/home/inglorion/clang/test/ThinLTO/X86/Output/diagnostic-handler-remarks-with-hotness.ll.tmp-no-th.yaml.thin.0.yaml | /usr/local/goog
>  le/home/inglorion/clang/bin/FileCheck /usr/local/google/home/inglorion/llvm/llvm/test/ThinLTO/X86/diagnostic-handler-remarks-with-hotness.ll
>   -check-prefix=YAML1
>  cat /usr/local/google/home/inglorion/clang/test/ThinLTO/X86/Output/diagnostic-handler-remarks-with-hotness.ll.tmp-low-th.yaml.thin.0.yaml |
>  /usr/local/google/home/inglorion/clang/bin/FileCheck /usr/local/google/home/inglorion/llvm/llvm/test/ThinLTO/X86/diagnostic-handler-remarks-
>  with-hotness.ll -check-prefix=YAML1
>  cat /usr/local/google/home/inglorion/clang/test/ThinLTO/X86/Output/diagnostic-handler-remarks-with-hotness.ll.tmp-high-th.yaml.thin.0.yaml |
>   /usr/local/google/home/inglorion/clang/bin/FileCheck /usr/local/google/home/inglorion/llvm/llvm/test/ThinLTO/X86/diagnostic-handler-remarks
>  -with-hotness.ll -allow-empty -check-prefix=YAML1_TH_HIGH
>  cat /usr/local/google/home/inglorion/clang/test/ThinLTO/X86/Output/diagnostic-handler-remarks-with-hotness.ll.tmp-no-th.yaml.thin.1.yaml | /
>  usr/local/google/home/inglorion/clang/bin/FileCheck /usr/local/google/home/inglorion/llvm/llvm/test/ThinLTO/X86/diagnostic-handler-remarks-w
>  ith-hotness.ll -check-prefix=YAML2
>  cat /usr/local/google/home/inglorion/clang/test/ThinLTO/X86/Output/diagnostic-handler-remarks-with-hotness.ll.tmp-low-th.yaml.thin.1.yaml |
>  /usr/local/google/home/inglorion/clang/bin/FileCheck /usr/local/google/home/inglorion/llvm/llvm/test/ThinLTO/X86/diagnostic-handler-remarks-
>  with-hotness.ll -allow-empty -check-prefix=YAML2_TH_HIGH
>  cat /usr/local/google/home/inglorion/clang/test/ThinLTO/X86/Output/diagnostic-handler-remarks-with-hotness.ll.tmp-high-th.yaml.thin.1.yaml |
>   /usr/local/google/home/inglorion/clang/bin/FileCheck /usr/local/google/home/inglorion/llvm/llvm/test/ThinLTO/X86/diagnostic-handler-remarks
>  -with-hotness.ll -allow-empty -check-prefix=YAML2_TH_HIGH
>  --
>  Exit Code: 1
> 
> 
> 
> Repository:
>  rL LLVM
> 
> https://reviews.llvm.org/D41465
> 
> 
>