[PATCH] D16403: Add scope information to CFG

[Artem Dergachev via Phabricator via llvm-commits]

NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

I think we should land this and celebrate.

@szepet: Ouch, i was sure i already answered this, sorry, dunno where this went.

> So, LoopExit and ScopeExit would be the same but the underlying TriggerStmt would decide which marks a loop and which marks a variable?

I was thinking of a single `CFGElement` to mark both. Which would probably be called "`ScopeExit`", but you could use it for detecting the end of the loop and, if necessary, add whatever information you need into it.



================
Comment at: lib/Analysis/CFG.cpp:1700
 /// way return valid LocalScope object.
 LocalScope* CFGBuilder::createOrReuseLocalScope(LocalScope* Scope) {
   if (Scope)
----------------
It seems that something  has moved asterisks to a weird spot, might be a rebase artifact or accidental tooling.


Repository:
  rL LLVM

https://reviews.llvm.org/D16403