[PATCH] D43536: [LV] Fix for PR36311, vectorizer's isUniform() abuse triggers assert in SCEV

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

Fair enough, I can't see what case this is trying to cover anyway. I'm happy with the line going out without a big comment, commit message is usually ok.

Sorry it took so long, I'm swapping a bit in the past few weeks.



================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:3051
   if (SI) {
-    assert(!Legal->isUniform(SI->getPointerOperand()) &&
-           "We do not allow storing to uniform addresses");
+    // TODO
+    // Quick workaround for PR36311 by commenting out the assert for which
----------------
hsaito wrote:
> mkazantsev wrote:
> > I'd rather prefer FIXME here.
> Changed the comment such that it is actually a TODO for how one can enable store to uniform addr.
This TODO is confusing. I'm not sure what's the thing we want to do in the future...

Maybe adding that big description on the commit message and a short message for the exact thing we want to implement here, for example, "detect cases where..."


https://reviews.llvm.org/D43536