[PATCH] D44225: Fix identification of COFF executable files

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 7 15:38:54 PST 2018


rnk added a comment.

Most callers already map the whole file and then call the other identify_magic overload. Only llvm-pdbutil uses this overload. Maybe we should remove this overload and push the complexity of mapping the file up to there?


https://reviews.llvm.org/D44225





More information about the llvm-commits mailing list