[PATCH] D44184: Write DWARF data into WASM object file

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lib/MC/WasmObjectWriter.cpp:375
+      return;
+  }
 
----------------
No curly braces here.


================
Comment at: lib/MC/WasmObjectWriter.cpp:891
+  //   target
+  //   addend
+  // TODO: It is possible to have running table of section codes to compress
----------------
There should be one reloc section for each wasm section that contains relocs.

So I think this should generate multiple relocations sections with names like `reloc.debug_strings` etc..

Each of the reloc sections starts by specifying the target section, then each relocation entry doesn't need to specify the target section. 

See: https://github.com/WebAssembly/tool-conventions/blob/master/Linking.md

Maybe there is some reason why this doesn't work for you?


================
Comment at: lib/MC/WasmObjectWriter.cpp:1011
+      continue;
+    }
+
----------------
remove curlys


================
Comment at: lib/MC/WasmObjectWriter.cpp:1021
+
+    //writeDebugSection(Asm, DebugSection, Layout);
+  }
----------------
remove comment


Repository:
  rL LLVM

https://reviews.llvm.org/D44184